forbid spelling pointer types that are not instantiable #1427
Assignees
Labels
Comments
dneto0
added a commit
to dneto0/cts
that referenced
this issue
Jul 10, 2023
…ions Check combinations of address space and access mode. Check that we can read from any pointer. Check that we can write to pointers that we should be able to, including when the let infers the pointer type. The store type of a pointer must be instantiable as the store type of a variable that could be declared somewhere. A function formal parameter must not be pointer to workgroup, where the store type is atomic or contains an atomic. Fixes: gpuweb#2832 gpuweb#1427 gpuweb#1589
7 tasks
dneto0
added a commit
that referenced
this issue
Jul 12, 2023
* Refactor helpers into util.js * Fix logic of picking a valid address space. * Fix addressSpaceExpander When expansion produces an empty list, it kills the parameterization. Instead, generate a list with an empty string. Propagate the type signatures as needed. * Validate ptr type spelling for lets and params of user-declared functions Check combinations of address space and access mode. Check that we can read from any pointer. Check that we can write to pointers that we should be able to, including when the let infers the pointer type. The store type of a pointer must be instantiable as the store type of a variable that could be declared somewhere. A function formal parameter must not be pointer to workgroup, where the store type is atomic or contains an atomic. Fixes: #2832 #1427 #1589 * Avoid adding address space info to t.params Push the lookup of address space info into the helpers. * s/explicitMode/explicitAccess/ Per review feedback * Drop redundant "as string"
|
Fixed by #2840 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From spec change gpuweb/gpuweb#2904
E.g. the following shaders must produce shader-creation error
The text was updated successfully, but these errors were encountered: