Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit the overrides in the shader interface, to those that are "statically accessed" #1991

Closed
dneto0 opened this issue Nov 17, 2022 · 3 comments
Labels

Comments

@dneto0
Copy link
Contributor

dneto0 commented Nov 17, 2022

The definition of "statically accessed" is now recursive in more interesting ways, to make sure it pulls in the right set of overrides.

gpuweb/gpuweb#3600

@dneto0 dneto0 added the wgsl label Nov 17, 2022
@dj2
Copy link
Member

dj2 commented May 2, 2024

Is there a test that can be written for this? If we use the override it's accessed .... if we don't use it, how do we test that it wasn't included?

@kainino0x
Copy link
Collaborator

I'm not sure what the behavior is supposed to be here. See gpuweb/gpuweb#4624

@dj2
Copy link
Member

dj2 commented May 15, 2024

Obsolete

@dj2 dj2 closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

4 participants
@dj2 @kainino0x @dneto0 and others