Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test depth stencil formats in color formats tests #77

Closed
beaufortfrancois opened this issue Oct 25, 2019 · 2 comments · Fixed by #78
Closed

Don't test depth stencil formats in color formats tests #77

beaufortfrancois opened this issue Oct 25, 2019 · 2 comments · Fixed by #78
Assignees

Comments

@beaufortfrancois
Copy link
Collaborator

"color formats must be renderable" test fails because depth stencil format were added in 840ff3f#diff-a4c78fe12bb75d8679eab0ed0211c06d while they were not part of the original test.

Screen Shot 2019-10-25 at 9 42 12 AM

@kainino0x
Copy link
Collaborator

Whoops. I think we should still test them - just add the necessary metadata to the format info table so we can say "should error". (e.g. color: boolean or something)

@beaufortfrancois
Copy link
Collaborator Author

Do you have a fix already or should I assign it to me now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants