Allow marking tests as explicitly unimplemented #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for test structure to be committed into the CTS before the tests themselves are implemented.
austinEng
approved these changes
Nov 3, 2020
src/common/framework/test_group.ts
Outdated
| assert(this.testFn !== undefined, () => { | ||
| let s = `Test is missing .fn(): ${testPathString}`; | ||
| if (this.testConstructorStack.stack) { | ||
| s += `\n-> test created at:\n${this.testConstructorStack.stack}`; |
There was a problem hiding this comment.
at least in Chrome, i think this will say:
-> test created at:
Error
___ at ...
___ at ...
I remember you may have some utilities elsewhere that separate the "Error" message and the stack ?
There was a problem hiding this comment.
yes, in chrome it will. I think I used to have utilities to do that but they just stripped the first line from the message, and that doesn't actually work (message could have a newline in it, some engines don't put a line at the top of .stack, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for test structure to be committed into the CTS before the
tests themselves are implemented.
Also hide SKIP error messages when not in "debugging" mode.