Specify [=debug label=]. #1240
Specify [=debug label=]. #1240
Conversation
* We SHOULD preserve length/charset * We MUST NOT use labels in (WebGPU-implementation) heuristics * Note that there may be not clear mapping for a label.
| </dl> | ||
|
|
||
|
|
||
| : <dfn dfn>Debug label</dfn> |
There was a problem hiding this comment.
optional nit: The :/:: syntax is shorthand for <dt>/<dd> and inserts an implicit <dl> wrapper if there isn't one. So in this case this should render like a <dl>. Maybe it would be better if it just looks like a paragraph? (Otherwise I kind of feel like it needs something before it, describing what the list is, like "has the following members:" above.)
| :: A string provided for use by development tools (such as error/warning messages, | ||
| browser developer tools, or platform debugging utilities) to identify the underlying | ||
| [=internal object=], debug group, or debug marker to the developer. | ||
| It has no specified format, and implementations MUST NOT use label contents in heuristics. |
There was a problem hiding this comment.
nit: We don't normally all-caps the RFC 2119 words. Though it would be cool if they could be highlighted like in Vulkan....
| :: A string provided for use by development tools (such as error/warning messages, | ||
| browser developer tools, or platform debugging utilities) to identify the underlying | ||
| [=internal object=], debug group, or debug marker to the developer. | ||
| It has no specified format, and implementations MUST NOT use label contents in heuristics. |
There was a problem hiding this comment.
nit: not just heuristics, it must not affect behavior at all.
There was a problem hiding this comment.
nit: I think we use the "should not" wording because there's no way to enforce the "must not" behavior via tests.
There was a problem hiding this comment.
I think we can and should keep "must not" even though it's not enforceable.
| @@ -513,6 +508,29 @@ interface mixin GPUObjectBase { | |||
| An internal slot holding the [=device=] which owns the [=internal object=]. | |||
| </dl> | |||
|
|
|||
| {{GPUObjectDescriptorBase}} has the following members: | |||
|
|
|||
| <dl dfn-type=dict-member dfn-for=GPUObjectDescriptorBase> | |||
There was a problem hiding this comment.
Why is this moved? Seems like it should stay next to its IDL.
|
|
||
|
|
||
| : <dfn dfn>Debug label</dfn> | ||
| :: A string provided for use by development tools (such as error/warning messages, |
There was a problem hiding this comment.
reads slightly ambiguous to me: is the string provided by the dev tools, or used by the dev tools. May need to be reworded slightly
|
This looks stalled. Can the comments be addressed or should the PR be closed? |
kainino0x
added
the
copyediting
This CL adds unimplemented stubs for the `step` builtin. Issue: gpuweb#1240
kainino0x
added
the
moved-m0-to-m1
Resolves #1211.
Preview | Diff