Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operator== for classes with matrix representations #16

Closed
lelemmen opened this issue Sep 10, 2018 · 2 comments
Closed

Add operator== for classes with matrix representations #16

lelemmen opened this issue Sep 10, 2018 · 2 comments
Assignees
@lelemmen
Labels
novel A novel feature addition to the project

Comments

@lelemmen
Copy link
Collaborator

lelemmen commented Sep 10, 2018 •
edited
Loading

It would be nice to implement .isEqualTo(other, tolerance) and operator==() that refers to a default tolerance for the matrix representations of both OneElectronOperator and TwoElectronOperator.
@lelemmen lelemmen added the novel A novel feature addition to the project label Sep 10, 2018
@lelemmen lelemmen mentioned this issue Oct 18, 2018
Closed
@lelemmen
Copy link
Collaborator Author

The same should/could be done for 1- and 2-DMs.

@lelemmen lelemmen self-assigned this Oct 26, 2018
@lelemmen lelemmen changed the title Add operator== for OneElectronOperator and TwoElectronOperator Add operator== for classes with matrix representations Oct 30, 2018
@lelemmen lelemmen mentioned this issue Oct 31, 2018
Merged
@lelemmen
Copy link
Collaborator Author

This was implemented in #102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lelemmen lelemmen

Labels
novel A novel feature addition to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lelemmen