Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement UniqueTypeNames validation rule #5

Closed
klavs opened this issue Oct 3, 2019 · 1 comment · Fixed by #56
Closed

Implement UniqueTypeNames validation rule #5

klavs opened this issue Oct 3, 2019 · 1 comment · Fixed by #56
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@klavs
Copy link
Contributor

klavs commented Oct 3, 2019

Implement UniqueTypeNames validation rule (ref)

Unlike graphql-js, there is no validation context given when validating a document. A schema validation rule should be self-sufficient and based only on the given AST document.
See https://github.com/gql-dart/gql/tree/master/gql/lib/src/validation.
@klavs klavs added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 3, 2019
@klavs klavs mentioned this issue Oct 3, 2019
Open
14 tasks
@jonas-jonas jonas-jonas mentioned this issue Feb 16, 2020
Merged
@jonas-jonas
Copy link
Contributor

I opened #56. If you have any feedback, I'm happy to incorporate that into the PR.

@klavs klavs closed this as completed in #56 Feb 16, 2020
@jonas-jonas jonas-jonas mentioned this issue Feb 18, 2020
Merged
klavs pushed a commit that referenced this issue Sep 22, 2020
@agent3bood
Merge pull request #5 from gql-dart/master
9033fa1 
Staying up to date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement UniqueTypeNames rule jonas-jonas/gql
2 participants
@klavs @jonas-jonas