-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bookmarks: restore Delete key #1312
bookmarks: restore Delete key #1312
Conversation
Should work (didn't test actually). A simpler solution may be to change the context of the global shortcut so it is limited to the plotter, but maybe this isn't what you want (eg. in this case it won't work when the focus is on the settings). Not for myself : if this PR is merged, last commit of #1308 shall be removed (and probably some conflicts be managed). |
I think the Delete should work wherever it's not needed for something else. There could be a better way of doing this, but I couldn't think of one. |
If this is what you're wanting, I think this is the right way. |
Another option is to use CTRL-Delete or some other key to clear the waterfall. Delete seemed more obvious than some random key. |
'C' as Clear can work but maybe already in use. |
That CW/L or CW/H with SHIFT. After a while you end up with so many shortcuts that nobody can remember them all. |
Delete is used as a global shortcut to clear the waterfall. It is also used to delete a bookmark, when the bookmarks table has focus. Allow the bookmarks table to override the global Delete shortcut. Signed-off-by: Jeff Long <willcode4@gmail.com>
2f3978c
to
20a1fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look fine and work correctly. I'll merge once CI is happy.
20a1fb9
to
03ebc21
Compare
Delete is used as a global shortcut to clear the waterfall. It is also used to delete a bookmark when the bookmarks table has focus. Allow the bookmarks table to override the global Delete shortcut.
Delete is used by other widgets, e.g., text fields, and is handled there in a similar way by the Qt library.
Note - the bookmarks table holds focus until something else acquires it, so a second Delete will offer to delete the next bookmark. There is a confirmation step.
Fixes issue mentioned in #1298