Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookmarks: restore Delete key #1312

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

willcode
Copy link
Contributor

@willcode willcode commented Oct 12, 2023

Delete is used as a global shortcut to clear the waterfall. It is also used to delete a bookmark when the bookmarks table has focus. Allow the bookmarks table to override the global Delete shortcut.

Delete is used by other widgets, e.g., text fields, and is handled there in a similar way by the Qt library.

Note - the bookmarks table holds focus until something else acquires it, so a second Delete will offer to delete the next bookmark. There is a confirmation step.

Fixes issue mentioned in #1298

@0penBrain
Copy link

Should work (didn't test actually). A simpler solution may be to change the context of the global shortcut so it is limited to the plotter, but maybe this isn't what you want (eg. in this case it won't work when the focus is on the settings).

Not for myself : if this PR is merged, last commit of #1308 shall be removed (and probably some conflicts be managed).

@willcode
Copy link
Contributor Author

I think the Delete should work wherever it's not needed for something else. There could be a better way of doing this, but I couldn't think of one.

@0penBrain
Copy link

I think the Delete should work wherever it's not needed for something else. There could be a better way of doing this, but I couldn't think of one.

If this is what you're wanting, I think this is the right way.

@willcode
Copy link
Contributor Author

Another option is to use CTRL-Delete or some other key to clear the waterfall. Delete seemed more obvious than some random key.

@0penBrain
Copy link

'C' as Clear can work but maybe already in use.

@willcode
Copy link
Contributor Author

That CW/L or CW/H with SHIFT. After a while you end up with so many shortcuts that nobody can remember them all.

Delete is used as a global shortcut to clear the waterfall. It is
also used to delete a bookmark, when the bookmarks table has focus.
Allow the bookmarks table to override the global Delete shortcut.

Signed-off-by: Jeff Long <willcode4@gmail.com>
@argilo argilo force-pushed the fix/restore-bookmark-delete-key branch from 2f3978c to 20a1fb9 Compare October 19, 2023 20:20
Copy link
Member

@argilo argilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine and work correctly. I'll merge once CI is happy.

@argilo argilo force-pushed the fix/restore-bookmark-delete-key branch from 20a1fb9 to 03ebc21 Compare October 19, 2023 20:25
@argilo argilo merged commit 91a87cf into gqrx-sdr:master Oct 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants