Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event paymentMethodSelected #29

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

douglaseggleton
Copy link
Collaborator

Adds the payment method selected event to Embed - However this does not work as documented in https://gr4vy.com/docs/next/embed/events#paymentmethodselected <- Can we change the documentation? @cbetta

I think there are two category of events UI Events (Clicked/Selected) and Resource events (Saved/Changed/Updated something)

@douglaseggleton douglaseggleton added release Create a release when this pr is merged patch Increment the patch version when merged labels Oct 20, 2021
Copy link
Contributor

@steve-gr4vy steve-gr4vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@douglaseggleton douglaseggleton merged commit 51fd929 into main Oct 20, 2021
@douglaseggleton douglaseggleton deleted the payment-method-events branch October 20, 2021 15:27
@gr4vy-code
Copy link
Collaborator

🚀 PR was released in v1.4.1 🚀

@gr4vy-code gr4vy-code added the released Issue or pull request released label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released Issue or pull request released
Development

Successfully merging this pull request may close these issues.

3 participants