Change environment usage to point at different URLs #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbetta
changed the title
douglaseggleton
added
release
douglaseggleton
approved these changes
Nov 17, 2021
douglaseggleton
changed the title
douglaseggleton
changed the title
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change environments to production and sandbox (removing staging and development options).
Use environment to determine
iframeHostandapiHost.iframeHostembed.{gr4vy_id}.gr4vy.appembed.sandbox.{gr4vy_id}.gr4vy.appapiHostapi.{gr4vy_id}.gr4vy.appapi.sandbox.{gr4vy_id}.gr4vy.appEmbedUI
In EmbedUI we've removed all usage of the
environmentparameter. See https://github.com/gr4vy/embed-ui/pull/148.One remaining question is if we need to stop the
environmentprop from being sent EmbedUI.Release Notes
The
environmentproperty can now only be set to eitherproductionorsandbox. Thesandboxvalue is a new value that replaces both thedevelopmentand 'stagingvalues that were previously used. Theenvironment` variable will now be used to connect to the right Gr4vy instance.