Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the loading state for Google Pay #69

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Show the loading state for Google Pay #69

merged 4 commits into from
Mar 9, 2022

Conversation

tculigGr4vy
Copy link
Contributor

On receiving a void overlay via the modeUpdate IPC the overlay will be closed.

@tculigGr4vy tculigGr4vy force-pushed the TA-957-embed-ui-google-pay-overlay branch from 6d53e0a to 49934ac Compare March 8, 2022 09:21
@tculigGr4vy tculigGr4vy force-pushed the TA-957-embed-ui-google-pay-overlay branch from 49934ac to 3e14a1d Compare March 8, 2022 09:38
thomas-gr4vy
thomas-gr4vy approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@thomas-gr4vy thomas-gr4vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There are a couple of vulnerabilities being picked up by Trivy. Make sure that this branch is up-to-date with main. You may have to address some of these if they are not already covered.

@tculigGr4vy tculigGr4vy changed the title Adding overlay control for Google Pay Show the loading state for Google Pay Mar 9, 2022
@tculigGr4vy tculigGr4vy added patch Increment the patch version when merged release Create a release when this pr is merged labels Mar 9, 2022
@tculigGr4vy tculigGr4vy merged commit 012896b into main Mar 9, 2022
@tculigGr4vy tculigGr4vy deleted the TA-957-embed-ui-google-pay-overlay branch March 9, 2022 11:15
@gr4vy-code
Copy link
Collaborator

🚀 PR was released in v2.8.2 🚀

@gr4vy-code gr4vy-code added the released Issue or pull request released label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-gr4vy thomas-gr4vy thomas-gr4vy approved these changes

@douglaseggleton douglaseggleton Awaiting requested review from douglaseggleton

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released Issue or pull request released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tculigGr4vy @gr4vy-code @thomas-gr4vy