-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: Make it easier to understand loaded Embed/Embed UI #84
Conversation
I like this approach @luca-gr4vy. I would not worry about getting the EmbedUI version if it doesn't load, that's fine. I do agree with @douglaseggleton's point about the EmbedUI version not being a version but more of a hash. I am not even sure we can read this in any way. |
@luca-gr4vy to confirm: this does not bundle the whole package.json into the frontend library, right? |
@douglaseggleton was suggesting we could try to somehow display that as a custom header in the static script response, like the other idea I had was to write a simple node script that runs on |
it shouldn't, thanks to the webpack approach but I'll certainly double-check |
Updated to use |
Perfect. Love it. |
🚀 PR was released in |
Description: Adds the package version information to a global
gr4vy.version.embed
variable. Ifembed-ui
is loaded correctly, also addgr4vy.version.embed-ui
with that information (passed via theframeReady
event).Depends on: https://github.com/gr4vy/embed-ui/pull/279
Ticket: https://gr4vy.atlassian.net/browse/TA-1466
Note: Not really sure how we can pass the
embed-ui
version information if it doesn't even load (network error)Screenshots(s):
📦 Published PR as canary version:
2.11.2--canary.84.0b195a8.0
✨ Test out this PR locally via:
npm install @gr4vy/embed-react@2.11.2--canary.84.0b195a8.0 npm install @gr4vy/embed@2.11.2--canary.84.0b195a8.0 # or yarn add @gr4vy/embed-react@2.11.2--canary.84.0b195a8.0 yarn add @gr4vy/embed@2.11.2--canary.84.0b195a8.0