Include codesnippets into the Javadoc and exclude them from distribut… #65
Conversation
| 'defaultLicense', | ||
| 'defaultLicence', |
There was a problem hiding this comment.
Why did you remove these two keys? What effect does removing them have?
(I'm not familiar with that part of the code... @gilles-duboscq, do you know what this does?)
There was a problem hiding this comment.
Initially we were using the UK spelling. In an mx version we switched to US spelling. There is mx_compat support for that so that we can still load older suites.
I don't think we should remove these keys.
If there is a problem such as mx silently ignoring the old version of the keys, then we need a different solution were we first read the mxversion and then add the keys with the current spelling to the list of supported keys using mx_compat. But that would anyway be work for an other pull request.
There was a problem hiding this comment.
I am sorry guys. I thought the keys are duplicated. I haven't noticed the difference in "s" vs. "c". I update my diff.
|
Now the diff contains only changes related to code snippets. Sorry for the noise and thanks for catching the error. |
|
Please also add a version bump, so users will get a "please update mx" message instead of a cryptic "unsupported suite attribute: snippetsPattern". |
…ion JARs if specified as 'snippetsPattern' : '.*SampleSnippets.*' in suite.py - increasing mx spec version to 5.13.0
|
All comments addressed. Merging. |
Include codesnippets into the Javadoc and exclude them from distribut…
… to master * commit '9e1f8cfeef4b8ff730cf23904926416a6c724ced': support compiling against JVMCI API on class path that differs from JVMCI API in JDK used for compilation
…ion JARs if specified as
'snippetsPattern' : '.*SampleSnippets.*'in suite.pyPull request to implement what has been discussed in #57