Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest mandrel when version not specified #69

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Nov 3, 2023

  • Get latest mandrel release if version not specified
  • Remove user-agent from HttpClient constructor

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 3, 2023
@fniephaus fniephaus force-pushed the 2023-11-03-adress-67-comments branch from cfb4583 to f8715fa Compare November 3, 2023 12:25
@fniephaus
Copy link
Member

Please regenerate the dist files.

@zakkak zakkak force-pushed the 2023-11-03-adress-67-comments branch from f8715fa to fb0d5aa Compare November 3, 2023 12:26
@zakkak
Copy link
Collaborator Author

zakkak commented Nov 3, 2023

Please regenerate the dist files.

Regenerated and added an extra test in CI

Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zakkak
Copy link
Collaborator Author

zakkak commented Nov 3, 2023

Shall I rebase?

@fniephaus
Copy link
Member

Shall I rebase?

Nope, it's fine.

@fniephaus fniephaus merged commit b8dc5fc into graalvm:main Nov 3, 2023
57 checks passed
@zakkak zakkak deleted the 2023-11-03-adress-67-comments branch November 3, 2023 12:31
@zakkak
Copy link
Collaborator Author

zakkak commented Nov 3, 2023

Thank you @fniephaus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants