Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Fix: public items #5

Open
codeofmochi opened this issue Jan 6, 2023 · 0 comments
Open

Fix: public items #5

codeofmochi opened this issue Jan 6, 2023 · 0 comments
Assignees
Labels
bug 🪲 Something isn't working

Comments

@codeofmochi
Copy link
Collaborator

codeofmochi commented Jan 6, 2023

Public items can currently not display the content of an etherpad when viewed from a unauthenticated user: this is because all group pads require sessions to be viewed.

To solve this:

  • when an item becomes public or pseudonymized, the pad is moved to a non-group pad. REQUIRE_SESSION must be set to false. If the item is set to private, the pad is set into a group again
  • however this is not enough: a non-group pad becomes editable by anyone. So the back-end must ensure that the public endpoints always return a read-only ID, and the private endpoints need to check for a permission >= write to provide an edit URL.

⚠️ public item in Graasp != non-group pad: a public item is not editable, while a non-group pad is. Hence the additional read / write URL distinction.

Update: it seems we cannot set REQUIRE_SESSION to false, otherwise all pads can be opened by name (including private ones in graasp) in the Etherpad UI. To check with actual etherpad instance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant