Refactor hybrid build classes and disabled generating intermediate android_library resources target
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkumar9t2
requested review from
minkuan88,
roscrazy,
rifqimfahmi and
mohamadk
as code owners
arunkumar9t2
force-pushed
the
cleanup-hybrid-build
branch
from
d3743a0
to
3341a29
Compare
rifqimfahmi
approved these changes
Mar 14, 2023
akshay-grabtaxi
pushed a commit
that referenced
this pull request
Jun 28, 2023
…ndroid_library` resources target (#67) Cleanup hybrid build
akshay-grabtaxi
pushed a commit
that referenced
this pull request
Jun 28, 2023
…ndroid_library` resources target (#67) Cleanup hybrid build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Cleans up hybrid build classes and refactor them to use DI
Introduce hybrid build extension to control hybrid instead of gradle property
grazel.bazelEnabledFor supporting hybrid builds we used to generate a
android_libraryres target for holding resources, that is removed in this PR. A proper approach would be to write something todatabinding_aarin bazel_common and use that here to simply the amount of work grazel needs to do.Note: Hybrid builds does not work after variant specific Bazel targets support was added. #66 still remains open and this PR does not fix the issue. Probably needs a larger refactor to accomodate variants and to move away from doing everything in configuration phase.