Remove databinding flag from grazel extension as it is supported by default. Support viewbinding.
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default. Support `viewbinding`. Since `bazel-common` is by default used for all targets, remove databinding from migration criteria check. Signed-off-by: arun.sampathkumar <arun.sampathkumar@grabtaxi.com>
arunkumar9t2
requested review from
roscrazy,
rifqimfahmi and
mohamadk
as code owners
minkuan88
approved these changes
Jun 13, 2023
akshay-grabtaxi
pushed a commit
that referenced
this pull request
Jun 28, 2023
… default. Support `viewbinding`. (#84) Since `bazel-common` is by default used for all targets, remove databinding from migration criteria check. Signed-off-by: arun.sampathkumar <arun.sampathkumar@grabtaxi.com>
akshay-grabtaxi
pushed a commit
that referenced
this pull request
Jun 28, 2023
… default. Support `viewbinding`. (#84) Since `bazel-common` is by default used for all targets, remove databinding from migration criteria check. Signed-off-by: arun.sampathkumar <arun.sampathkumar@grabtaxi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
bazel-commonis by default used for all targets since #73, remove databinding from migration criteria check.