Add config flag to exclude credentials for maven install repositories #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minkuan88
requested review from
roscrazy,
arunkumar9t2,
rifqimfahmi and
mohamadk
as code owners
grazel-gradle-plugin/src/main/kotlin/com/grab/grazel/extension/MavenInstallExtension.kt
Outdated
Show resolved
Hide resolved
arunkumar9t2
approved these changes
Jun 17, 2023
arunkumar9t2
approved these changes
Jun 18, 2023
akshay-grabtaxi
pushed a commit
that referenced
this pull request
Jun 28, 2023
…#87) * Add config flag to exclude credentials for maven install repositories * Change config flag for credentials to a more descriptive name (includeCredentials)
akshay-grabtaxi
pushed a commit
that referenced
this pull request
Jun 28, 2023
…#87) * Add config flag to exclude credentials for maven install repositories * Change config flag for credentials to a more descriptive name (includeCredentials)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Current setup reads repository credentials and expose it in
WORKSPACEfile. This MR adds a flag to enable or disable exposing credentials intoWORKSPACETesting
Issues Fixed