More demo fixes #2656
Merged
More demo fixes #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyaboulton
commented
Nov 15, 2022
| @@ -1,2 +1,3 @@ | |||
| psycopg2 | |||
| matplotlib | |||
| SQLAlchemy | |||
There was a problem hiding this comment.
Can't use pd.read_sql without SQLAlchemy
freddyaboulton
commented
Nov 15, 2022
| @@ -13,6 +13,8 @@ def get_plot(period=1): | |||
| y = np.sin(2*math.pi*period * x) | |||
| fig = px.line(x=x, y=y) | |||
| plot_end += 2 * math.pi | |||
| if plot_end > 1000: | |||
There was a problem hiding this comment.
To prevent calling sine on really large values
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2656-all-demos |
freddyaboulton
commented
Nov 15, 2022
| You can see the demo below as well: | ||
|
|
||
| <gradio-app space="gradio/english-to-german"> </gradio-app> |
There was a problem hiding this comment.
There was a typo in the space name as well
freddyaboulton
force-pushed
the
some-more-demo-fixes
branch
from
dfe421c
to
53bd647
Compare
freddyaboulton
requested review from
pngwn,
abidlabs,
aliabd,
aliabid94 and
dawoodkhan82
|
All these changes LGTM @freddyaboulton, thanks! |
abidlabs
approved these changes
Nov 16, 2022
|
Thanks for the review @abidlabs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another day, another demo pr 😂
Just some minor tweaks. Main issue I noticed is that the markdown conversion will treat text enclosed in underscored to italics which well prevent the demo from loading. So
chicago_bike_dashboardturned intochicago_<em>bike<\em>_dashboardin thegradio-apptag.Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.