Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperlinks to download files in chatbot #4848

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Add hyperlinks to download files in chatbot #4848

merged 3 commits into from
Jul 10, 2023

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Add hyperlinks to download files in chatbot

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #4667

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests & Changelog

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

  3. Unless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in CHANGELOG.md:

Please add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by [@myusername](link-to-your-github-profile) in [PR 11111](https://github.com/gradio-app/gradio/pull/11111)".

@vercel
Copy link

vercel bot commented Jul 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gradio ✅ Ready (Inspect) Visit Preview Jul 9, 2023 7:28pm

@gradio-pr-bot
Copy link
Collaborator

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4848-all-demos

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 9, 2023

Chromatic build successful 🎉

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goo to me! Thanks for adding this @dawoodkhan82!

@dawoodkhan82 dawoodkhan82 merged commit 504c9d9 into main Jul 10, 2023
@dawoodkhan82 dawoodkhan82 deleted the file-link branch July 10, 2023 14:34
@abidlabs
Copy link
Member

Nice @dawoodkhan82! We should update the docstring of gr.Chatbot to reflect this change. I can open a quick PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chatbot does not show PDF file
4 participants