-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Blocks.load()
so that it is in the same style as the other listeners
#6126
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f388a12
restore decorator
abidlabs 6f1cdad
remove
abidlabs 292949d
refactor load
abidlabs 8ccaf14
remove restriction
abidlabs 07d5fd1
add changeset
gradio-pr-bot 88ffd6d
add pyi
abidlabs 6190491
Merge branch 'decorator' of github.com:gradio-app/gradio into decorator
abidlabs 41f8892
add test
abidlabs 45bf1c1
add test
abidlabs 8f6c163
fix tests
abidlabs 62eb60b
metaclass
abidlabs 1257b91
future
abidlabs 3c8bffb
reduce'
abidlabs 78b6996
docstring
abidlabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@gradio/app": minor | ||
"gradio": minor | ||
--- | ||
|
||
feat:Refactor `Blocks.load()` so that it is in the same style as the other listeners |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
from __future__ import annotations | ||
|
||
from gradio.component_meta import create_or_modify_pyi | ||
from gradio.events import EventListener, Events | ||
|
||
BLOCKS_EVENTS: list[EventListener | str] = [Events.load] | ||
|
||
|
||
class BlocksMeta(type): | ||
def __new__(cls, name, bases, attrs): | ||
for event in BLOCKS_EVENTS: | ||
trigger = ( | ||
event | ||
if isinstance(event, EventListener) | ||
else EventListener(event_name=event) | ||
).copy() | ||
trigger.set_doc(component=name) | ||
attrs[event] = trigger.listener | ||
component_class = super().__new__(cls, name, bases, attrs) | ||
create_or_modify_pyi(BlocksEvents, "BlocksEvents", BLOCKS_EVENTS) | ||
return component_class | ||
|
||
|
||
class BlocksEvents: | ||
""" | ||
This class is used to hold the events for the Blocks component. It is populated dynamically | ||
by the BlocksMeta metaclass. | ||
""" | ||
|
||
pass |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a docstring here explaining why we have this even though it's empty