Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for numpy~=2.0 #8440

Merged
merged 10 commits into from
Jun 3, 2024
Merged

Add support for numpy~=2.0 #8440

merged 10 commits into from
Jun 3, 2024

Conversation

freddyaboulton
Copy link
Collaborator

Description

Numpy 2.0 is being released in two weeks and we were using two APIs that will be deprecated:
https://numpy.org/devdocs/numpy_2_0_migration_guide.html#main-namespace

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 3, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/97fec95f27ac05029d5feeff3b44fcdffc1d7653/gradio-4.32.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@97fec95f27ac05029d5feeff3b44fcdffc1d7653#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/97fec95f27ac05029d5feeff3b44fcdffc1d7653/gradio-client-0.20.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 3, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add support for numpy~=2.0

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton marked this pull request as ready for review June 3, 2024 15:49
@freddyaboulton freddyaboulton added v: patch A change that requires a patch release t: fix A change that implements a fix labels Jun 3, 2024
@abidlabs
Copy link
Member

abidlabs commented Jun 3, 2024

Thanks @freddyaboulton for checking this! Going to push an update to requirements.txt to support numpy>=1.0,<3.0, will allow me to test it out more easily too

@freddyaboulton
Copy link
Collaborator Author

Thanks @abidlabs !

@abidlabs abidlabs changed the title Numpy 2.0 compatibility Add support for numpy~=2.0 Jun 3, 2024
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @freddyaboulton!

Installed this PR here along with numpy==2.0.0rc2 and all the demos that I tested work well.

@freddyaboulton
Copy link
Collaborator Author

Thank you so much for the review @abidlabs !!

@freddyaboulton freddyaboulton merged commit 83bdf5c into main Jun 3, 2024
7 checks passed
@freddyaboulton freddyaboulton deleted the numpy-2.0-compatibility branch June 3, 2024 21:46
@pngwn pngwn mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants