Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use root url for monitoring url #8506

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Use root url for monitoring url #8506

merged 6 commits into from
Jun 11, 2024

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Jun 8, 2024

Closes: #8494

Ensures that the correct /monitoring URL is shown if running with root url or running on HF Spaces, etc.

Also ensures that non-logged in users can't hit /monitoring

@abidlabs abidlabs changed the title use root url for monitoring url Use root url for monitoring url Jun 8, 2024
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 8, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/c804b720e023030e76405eef78f09ff390254ec9/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c804b720e023030e76405eef78f09ff390254ec9#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/c804b720e023030e76405eef78f09ff390254ec9/gradio-client-1.1.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 8, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Use root url for monitoring url

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abidlabs - only comment is that I would write a unit test for this!

@abidlabs
Copy link
Member Author

Yup will do, thanks @freddyaboulton!

@abidlabs abidlabs merged commit 7c5fec3 into main Jun 11, 2024
2 checks passed
@abidlabs abidlabs deleted the monitoring-root branch June 11, 2024 09:25
@pngwn pngwn mentioned this pull request Jun 10, 2024
@pngwn pngwn mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect monitoring URL when using the root_path parameter
3 participants