Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom components on windows #8531

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Fix custom components on windows #8531

merged 5 commits into from
Jun 13, 2024

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Jun 11, 2024

Description

image

Closes: #6821
Closes: #7025

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 11, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/86d007997fabacde4a0849a0cca29a97f125f799/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@86d007997fabacde4a0849a0cca29a97f125f799#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/86d007997fabacde4a0849a0cca29a97f125f799/gradio-client-1.1.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 11, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/preview patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix custom components on windows

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton marked this pull request as ready for review June 11, 2024 17:53
@pngwn
Copy link
Member

pngwn commented Jun 13, 2024

Does everything still work in mac/linux?

@freddyaboulton
Copy link
Collaborator Author

Yes tested on mac!

@freddyaboulton
Copy link
Collaborator Author

I guess the true test would be to do ship an release candidate of @gradio/preview but everything is working in the dev environment

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (macOs and Asahi linux) and looks good!

Thanks @freddyaboulton!

@freddyaboulton
Copy link
Collaborator Author

Thank you @pngwn 🙏

@freddyaboulton freddyaboulton merged commit 88de38e into main Jun 13, 2024
9 checks passed
@freddyaboulton freddyaboulton deleted the fix-cc-path-windows branch June 13, 2024 21:26
@pngwn pngwn mentioned this pull request Jun 13, 2024
@pngwn pngwn mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants