Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First time loading performance optimization #8571

Merged
merged 11 commits into from
Jun 20, 2024

Conversation

baojianting
Copy link
Contributor

@baojianting baojianting commented Jun 17, 2024

Description

When there are too many components on a page, the first loading can be time-consuming. The /info request cost about 500ms. It can be optimized. Just like gradio_config.

Closes: #8570

🎯 PRs Should Target Issues

First time loading performance issue

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 17, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/95afc612546021f949be72a5e573a21eb2db18f9/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@95afc612546021f949be72a5e573a21eb2db18f9#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/95afc612546021f949be72a5e573a21eb2db18f9/gradio-client-1.1.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 19, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app patch
@gradio/client patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

First time loading performance optimization

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Jun 19, 2024
@abidlabs abidlabs requested a review from pngwn June 19, 2024 15:32
globals.d.ts Outdated Show resolved Hide resolved
@abidlabs
Copy link
Member

Thanks @baojianting, this generally looks good to me, but I left one comment above. I'm also going to ping @pngwn for a review here.

@baojianting
Copy link
Contributor Author

Thanks @baojianting, this generally looks good to me, but I left one comment above. I'm also going to ping @pngwn for a review here.

OK, I have fixed it

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Tested everything and seems to work well. Thanks @baojianting!

@pngwn pngwn merged commit a77877f into gradio-app:main Jun 20, 2024
8 checks passed
This was referenced Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First time loading performance issue
5 participants