Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sample check configurable to use repository mirrors #30

Closed
ljacomet opened this issue Sep 18, 2018 · 2 comments
Closed

Make sample check configurable to use repository mirrors #30

ljacomet opened this issue Sep 18, 2018 · 2 comments

Comments

@ljacomet
Copy link
Member

ljacomet commented Sep 18, 2018

When testing samples, there is no mirroring of repositories possible AFAICT. This is causing noise in CI due to the Bintray availability issues.
sample-check should be enhanced so that it can run with an option similar to GradleExecuter.withRepositoryMirrors() to reduce flakiness in execution.

@wolfs
Copy link
Member

wolfs commented Sep 18, 2018

It is now possible to customize the invocation from the runner: #27

That should be enough to implement this issue, right?

@eriwen
Copy link
Contributor

eriwen commented Sep 18, 2018

This is now possible using SampleModifiers after a1e9ad6. This is included in v0.6.0.

See the docs here: https://github.com/gradle/exemplar/#common-sample-modification

@eriwen eriwen closed this as completed Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants