Avoid using command-line modification to enhance build execution #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing `--no-daemon` on the command line, the same functionality is now acheived by writing a gradle.properties file when initializing Gradle User Home.
Instead of writing this file to a temp directory and referencing it on the Gradle command line, the init script is now written to Gradle User Home so that it is picked up automatically.
The generated gradle.properties file and init script are not cached, so need to be generated even when restoring from cache.
Instead of writing the URL to a file on disk, reading it later and using the Actions API to record the output parameter and write the notice, these things are now done directly via Actions commands emitted directly from the init script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using command-line switches to control the way Gradle builds will execute, we now add control files to Gradle User Home. This reduces the coupling between
gradle-build-actionand the actual Gradle invocation, making it easier to use the action functionality without the action needing to "own" the Gradle invocation.