This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Refine the dependencies.constraints {} DSL #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by generating accessors for known configurations by adding `classpath` accessor for buildscript.dependencies.constraints by adding a configuration scope with string invoke operators Signed-off-by: Paul Merlin <paul@gradle.com>
JLLeitschuh
reviewed
Sep 8, 2018
| * | ||
| * @see [DependencyConstraintHandler] | ||
| */ | ||
| class DependencyConstraintHandlerScope(val constraints: DependencyConstraintHandler) : DependencyConstraintHandler by constraints { |
There was a problem hiding this comment.
Shouldn't this be annotated with @Incubating the same way the underlying API is?
Signed-off-by: Paul Merlin <paul@gradle.com>
bamboo
suggested changes
Sep 13, 2018
| package org.gradle.kotlin.dsl.integration | ||
|
|
||
| import org.gradle.kotlin.dsl.fixtures.AbstractIntegrationTest | ||
| import org.gradle.kotlin.dsl.fixtures.containsMultiLineString |
| "direct-block:string-invoke", | ||
| "direct-block:string-invoke-with-action" | ||
| ).forEach { dep -> | ||
| build("dependencyInsight", "--configuration", "compileClasspath", "--dependency", dep).apply { |
There was a problem hiding this comment.
❌ Have you considered alternatives to avoid running that many builds?
There was a problem hiding this comment.
The dependencyInsight report is the sole one giving the required information and it can only target one dependency at a time. Those builds will reuse the daemon.
Signed-off-by: Paul Merlin <paul@gradle.com>
bamboo
approved these changes
Sep 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by generating accessors for known configurations
plugins { `java-library` } dependencies { constraints { api("some:thing") { version { strictly("1.0") } } } }by adding
classpathaccessor forbuildscript.dependencies.constraints {}buildscript { dependencies { constraints { classpath("some:thing") { version { strictly("1.0") } } } } }by adding a configuration scope with string invoke operators
dependencies { (constraints) { "api"("some:thing") { version { strictly("1.0") } } } }Note that the configuration scope with support for the string invoke syntax can only be used by explicitly resolving the
dependencies.constraintsproperty (the extra parentheses above).This happens because DependencyHandler.constraints(Action) would shadow a Kotlin extension providing the specialized configuration scope: