Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin DSL scope based configuration functions are shadowed by existing configuration methods #9248

Open
eskatos opened this issue Sep 18, 2018 · 2 comments

Comments

@eskatos
Copy link
Member

eskatos commented Sep 18, 2018

Expected Behavior

dependencies.constraints {
    "implementation"("com.google.collections:google-collections") {
        version { rejectAll() }
        because("Google collections is superceded by Guava")
    }
}

to add a dependency constraints on the implementation configuration.

Current Behavior

Doesn't compile with:

* What went wrong:
Script compilation error:

  Line 6:     "implementation"("com.google.collections:google-collections") {
              ^ Expression '"implementation"' of type 'String' cannot be invoked as a function. The function 'invoke()' is not found

1 error

because DependencyHandler.constraints(Action) would shadow a kotlin extension made available to configure via DependencyConstraintHandlerScope.

Workarounds

Don't use string invoke, prefer either the API or delegated properties.

Or explicitely use invoke():

dependencies.constraints.invoke {
    "implementation"("com.google.collections:google-collections") {
        version { rejectAll() }
        because("Google collections is superceded by Guava")
    }
}

Or explicitely resolve the constraints property:

(dependencies.constraints) {
    "implementation"("com.google.collections:google-collections") {
        version { rejectAll() }
        because("Google collections is superceded by Guava")
    }
}

Context

See #710

@eskatos eskatos changed the title Scope based configuration functions are shadowed by existing configuration methods Kotlin DSL scope based configuration functions are shadowed by existing configuration methods Apr 19, 2019
@eskatos eskatos transferred this issue from gradle/kotlin-dsl-samples Apr 25, 2019
@stale
Copy link

stale bot commented Sep 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Sep 6, 2020
@stale
Copy link

stale bot commented Sep 27, 2020

This issue has been automatically closed due to inactivity. If you can reproduce this on a recent version of Gradle or if you have a good use case for this feature, please feel free to reopen the issue with steps to reproduce, a quick explanation of your use case or a high-quality pull request.

@stale stale bot closed this as completed Sep 27, 2020
@wolfs wolfs closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
@eskatos eskatos removed the stale label Oct 6, 2023
@eskatos eskatos reopened this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants