feat(backup): add impl Display for BackupStatus

graelo · Aug 18, 2022 · e9baef7 · e9baef7
1 parent eca142d
commit e9baef7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/src/management/backup.rs b/src/management/backup.rs
@@ -1,17 +1,18 @@
 //! High-level representation of a backup for catalog operations and reporting.
 
+use std::fmt;
 use std::path::PathBuf;
 
 use chrono::NaiveDateTime;
 use clap::ValueEnum;
 
 /// Quick access, high-level representation of a backup.
 ///
+/// `Backup` provides only information which can be derived from the file name, avoiding to open
+/// the file, deal with the format, parse the metadata, etc.
+///
 /// This is sufficient for the [`Catalog`](crate::management::catalog::Catalog) to list backups
 /// and decide whether or not a backup should be deleted or kept.
-///
-/// `Backup` provides only information which can be derived from the file name. This avoids to open
-/// the file, deal with the format, parse the metadata, etc.
 pub struct Backup {
     /// Path to the backup file.
     pub filepath: PathBuf,
@@ -25,6 +26,16 @@ pub struct Backup {
 pub enum BackupStatus {
     /// Retainable backups only.
     Retainable,
+
     /// Disposable backups only.
     Disposable,
 }
+
+impl fmt::Display for BackupStatus {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        match self {
+            BackupStatus::Retainable => write!(f, "retainable"),
+            BackupStatus::Disposable => write!(f, "disposable"),
+        }
+    }
+}
diff --git a/src/management/catalog.rs b/src/management/catalog.rs
@@ -299,17 +299,13 @@ impl Catalog {
                     BackupStatus::Disposable => yellow,
                     BackupStatus::Retainable => green,
                 };
-                let status_str = match status {
-                    BackupStatus::Disposable => "disposable",
-                    BackupStatus::Retainable => "retainable",
-                };
                 let time_ago = Self::time_ago(now, backup.creation_date);
 
                 let overview = metadata.overview();
                 let version = &metadata.version;
 
                 println!(
-                        "{index:3}. {color}{filename:32}{reset} {time_ago:17} {color}{status_str:12}{reset} {version:8} {overview:8}"
+                        "{index:3}. {color}{filename:32}{reset} {time_ago:17} {color}{status:12}{reset} {version:8} {overview:8}"
                     );
             }
         } else {
@@ -323,15 +319,11 @@ impl Catalog {
                     BackupStatus::Disposable => yellow,
                     BackupStatus::Retainable => green,
                 };
-                let status_str = match status {
-                    BackupStatus::Disposable => "disposable",
-                    BackupStatus::Retainable => "retainable",
-                };
                 let time_ago = Self::time_ago(now, backup.creation_date);
 
                 println!(
-                        "{index:3}. {color}{filename:32}{reset} {time_ago:17} {color}{status_str:6}{reset}"
-                    );
+                    "{index:3}. {color}{filename:32}{reset} {time_ago:17} {color}{status:6}{reset}"
+                );
             }
         }