Some changes. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on the spot generation of records.
graemetait
added a commit
that referenced
this pull request
Jul 27, 2015
Can't store Faker in ClassRegistry like this, as ClassRegistry is reset before each test.
|
Sorry, but I've had to undo the changes that I'd previously merged. I finally had some time to test them with my projects today, and it broke almost all of my fixtures. It's my fault for not adding proper unit tests to this code, but I honestly didn't think anyone else would use it. :) We're obviously using this code in different ways though! It may be better just to fork? |
|
As I was working with it, I have to agree hehe. Sorry about the break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to update this library for our project (CakePHP 2) and made it a bit more flexible.