You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running npx yarn dev after having run npx run upgrade, the linter fails with two violations of the no-duplicate-imports rule in ESLint. This makes it impossible to build the plugin.
Steps to reproduce
Clone grafana-map-panel with git clone https://github.com/panodata/grafana-map-panel
Run npx yarn install
Run npx yarn dev. It should run without issue (at least it does on my machine). If it fails, skip to step 5.
If the previous step didn't fail, run npx yarn upgrade.
Run npx yarn dev again. It should fail with two 'leaflet' import is duplicated no-duplicate-imports errors, on files src/worldmap.ts and src/types/leaflet_plus.d.ts
Cause
When cloning and running npx yarn install, version 7.3.1 of package @grafana/toolkit is downloaded. This package requires version 2.0.3 of @grafana/eslint-config. These two versions come from the yarn.lock file.
(This issue was first reported by @falconhome in #97 (comment))
When running
npx yarn dev
after having runnpx run upgrade
, the linter fails with two violations of theno-duplicate-imports
rule in ESLint. This makes it impossible to build the plugin.Steps to reproduce
grafana-map-panel
withgit clone https://github.com/panodata/grafana-map-panel
npx yarn install
npx yarn dev
. It should run without issue (at least it does on my machine). If it fails, skip to step 5.npx yarn upgrade
.npx yarn dev
again. It should fail with two'leaflet' import is duplicated no-duplicate-imports
errors, on filessrc/worldmap.ts
andsrc/types/leaflet_plus.d.ts
Cause
When cloning and running
npx yarn install
, version 7.3.1 of package @grafana/toolkit is downloaded. This package requires version 2.0.3 of @grafana/eslint-config. These two versions come from theyarn.lock
file.After running
npx yarn upgrade
, @grafana/toolkit is (in my tests) upgraded to version 7.5.7, which specifies version 2.3.0 of @grafana/eslint-config. However, theno-duplicate-imports
rule was added on version 2.2.0 of @grafana/eslint-config.The text was updated successfully, but these errors were encountered: