Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cAdvisor integration set enable_load_reader #1656

Closed
rlankfo opened this issue Apr 28, 2022 · 3 comments
Closed

cAdvisor integration set enable_load_reader #1656

rlankfo opened this issue Apr 28, 2022 · 3 comments
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. stale Issue/PR mark as stale due lack of activity

Comments

@rlankfo
Copy link
Member

rlankfo commented Apr 28, 2022 •
edited

cAdvisor has a flag enable_load_reader which defaults to false. We should allow users to configure the agent's cAdvisor integration to set this value.
@rlankfo
Copy link
Member Author

rlankfo commented Apr 28, 2022

I've submitted the following PR to hopefully make this change simple: google/cadvisor#3108

If we can't get this merged we can probably figure out a hacky way to allow users to modify this value.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 30 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue/PR mark as stale due lack of activity label May 29, 2022
@rfratto rfratto added keepalive Never close from staleness and removed stale Issue/PR mark as stale due lack of activity keepalive Never close from staleness labels Jun 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 30 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue/PR mark as stale due lack of activity label Jul 9, 2022
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. stale Issue/PR mark as stale due lack of activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlankfo @rfratto