Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not build with upcoming Go 1.22 #6138

Closed
Tracked by #157782
stefanb opened this issue Jan 14, 2024 · 0 comments · Fixed by #6139
Closed
Tracked by #157782

Does not build with upcoming Go 1.22 #6138

stefanb opened this issue Jan 14, 2024 · 0 comments · Fixed by #6139
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@stefanb
Copy link
Contributor

stefanb commented Jan 14, 2024

What's wrong?

When attempting to build with Go 1.22rc1 it fails to build.

Noticed with v0.38.1 in

Steps to reproduce

  1. Install Go 1.22rc1
  2. Run make binaries
  3. See build error:
# github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.3/internal/pprof/delta_mutex.go:25:20: undefined: runtime_cyclesPerSecond
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.3/internal/pprof/proto.go:400:8: undefined: runtime_expandFinalInlineFrame

System information

All, irrelevant

Software version

Grafana Agent v0.39.0

Configuration

No special config, just building using default `Makefile`.

Logs

No response
@stefanb stefanb added the bug Something isn't working label Jan 14, 2024
This was referenced Jan 14, 2024
Merged
Merged
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump grafana/pyroscope-go to v0.1.6 to support Go 1.22
1 participant
@stefanb