Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web/ui): use named imports for React #972

Merged

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Jun 2, 2024

PR Description

React 18 now automatically injects JSX runtime during compilation so React import is no longer necessary. I also switch to named imports for currency and slightly better bundling.

I ran yarn start, yarn build. Everything stays identical to builds prior to this change.

Which issue(s) this PR fixes

N/A

Notes to the Reviewer

N/A

PR Checklist

Signed-off-by: hainenber <dotronghai96@gmail.com>
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wildum wildum merged commit 0508244 into grafana:main Jun 4, 2024
15 checks passed
@hainenber hainenber deleted the utilize-react-18-automatic-jsx-runtime branch June 9, 2024 15:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants