Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nodeSelector Affinity and Tolerations indentation #782

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix nodeSelector Affinity and Tolerations indentation #782

merged 1 commit into from
Apr 24, 2024

Conversation

georgesouzafarias
Copy link
Contributor

This patch fixes nodeSelector, Affinity and Tolerations indentation.

grcevski
grcevski approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks good to me. Those 3 settings should be under spec, not under containers.

mariomac
mariomac approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for the contribution

@mariomac mariomac merged commit 0f4c5cf into grafana:main Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

@mariomac mariomac mariomac approved these changes

@marctc marctc Awaiting requested review from marctc marctc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgesouzafarias @mariomac @grcevski