Fix sslVerify default=true for grafanaNet route using new syntax #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master:
When the value is not specified it should default to true.
Our code doesn't know the difference between unspecified and explicitly specified to false,
so it assumes the latter, and when unspecified, changes the value from the default (true) back to false.
With patch applied:
Notes:
It's unfortunate to have to patch the toml dependency code, I tried doing it more cleaner using
something like
meta.IsDefined("route", "sslverify")
but couldn't get that to workas we have a slice of routes, and the IsDefined doesn't seem to support iterating over a slice and finding
a specific route.