-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Generate builders for panels #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: in addition to the changes introduced by this PR, the diff includes unreleased changes living in
grafana-foundation-sdk@next+cog-v0.0.x |
K-Phoen
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so that we can keep iterating on this, but we need to fix the tests before merging 😬
The error is fixed in the other PR. |
K-Phoen
pushed a commit
that referenced
this pull request
May 21, 2024
* Generate builders for panels * Already fixed in other PR to avoid to add noise * Update comments * Fix casting * Add functions to all class templates * Fix defaults * Fix imports in panel template * Fix missing function error * Create generic function for template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #360
It generates panel's builders for Panels.
It adds a bit "hacky" things to make it works assuming that if there is a builder called "Panel" under a package, it needs a builder. Dashboard one is skipped since it already has a "Panel" builder and we could have file conflicts if we generate it twice.
Most of the changes in the template is to able to do cast to generic objects to be able to set the values. Also the functions that do the stuff have comments to be able to understand what they are doing if we need to re-check them in the future.