Add test for buildRequest with an already-escaped path #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincmoy
changed the title
|
@justincmoy Are you running into an issue with double escaping? Are you already setting your rule groups and rule namespaces to be escaped in the file? |
|
@justincmoy I have just seen your PR, after some investigation into the problem myself. Let me know if #140 fixes the double escaping you are experiencing |
|
@simonswine Yup #140 fixes the issue for me. Thanks for looking into it! |
|
By the way, I think I missed linking this PR with the issue. I'll close #132 too. |
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
Signed-off-by: Kevin Labesse <kevin@labesse.me> Co-authored-by: Ken Haines <khaines@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.