feat(DataSource): Persist the last selected data source #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test coverage
|
grafakus
changed the title
grafakus
commented
Jul 16, 2024
| }); | ||
|
|
||
| describe('if there is NO data source uid in the URL', () => { | ||
| describe('if there is a data source in local storage', () => { |
grafakus
commented
Jul 16, 2024
| expect(apiClient.baseUrl).toBe(expectedApiBaseUrl); | ||
| }); | ||
| }); | ||
| function setupMocks(options?: { appUrl?: string; bootData?: Record<string, any>; dataSources?: Record<string, any> }) { |
There was a problem hiding this comment.
I took the opportunity to refactor these tests by creating the setupMocks helper function.
korniltsev
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s): #42
📖 Summary of the changes
Now, when a user selects a different data source in the UI, it is stored in local storage.
This value is then used as default when the user revisits the Explore Profiles app.
🧪 How to test?
Manually, in an instance with multiple data sources: