Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV: replace rename file with copy and unlink #232

Merged
merged 1 commit into from
May 19, 2021
Merged

CSV: replace rename file with copy and unlink #232

merged 1 commit into from
May 19, 2021

Conversation

AgnesToulet
Copy link
Contributor

Rename can’t be used to rename across devices so this PR replaces renameSync with copyFileSync and unlinkSync.

@AgnesToulet AgnesToulet requested a review from xlson May 19, 2021 12:20
xlson
xlson approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@xlson xlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about nodejs but from my basic understanding that looks good :)

@AgnesToulet AgnesToulet merged commit 1d6e373 into master May 19, 2021
@AgnesToulet AgnesToulet deleted the csv-fix branch May 19, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlson xlson xlson approved these changes

@Clarity-89 Clarity-89 Clarity-89 approved these changes

@alexanderzobnin alexanderzobnin Awaiting requested review from alexanderzobnin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AgnesToulet @xlson @Clarity-89