Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add local hugo templates #1103

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Jun 12, 2023

@rodrigc rodrigc force-pushed the rodrigc/fix-broken-links-2 branch from 8108cf6 to 7e6721b Compare June 12, 2023 18:07
@NissesSenap
Copy link
Collaborator

NissesSenap commented Jun 12, 2023

So I think something is missing in the template.
If i push deployment in the middle of the page

image

I will get http://localhost:1313/docs/api/grafanaspecdeployment which is a 404.

While if I push on the sidebar on Grafana.spec.deployment I will get
http://localhost:1313/docs/api/#grafanaspecdeployment

This is the same way it currently works.

Could you take a second look? It might be a fundamental error in the tool itself.
One option would of course be to change tool, but when I looked a few years ago, I couldn't find a better option.

@rodrigc
Copy link
Contributor Author

rodrigc commented Jun 13, 2023

@NissesSenap I cannot reproduce the problem you mentioned clicking on Deployment. Can you make sure that you checkout the latest version of this branch and try again? I pushed one more small fix to the template this morning.

@NissesSenap
Copy link
Collaborator

Nether can I, either some strange cash or I checkout the wrong branch.
LGTM

@NissesSenap NissesSenap merged commit d724411 into grafana:master Jun 13, 2023
9 checks passed
@rodrigc rodrigc deleted the rodrigc/fix-broken-links-2 branch June 13, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants