Add environment variables configuring setting dashboard namespaces #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's only possible to configure dashboard namespaces through command line args. This makes it difficult to fine-tune the operator when installing it declaratively through an OLM subscription. This commit adds the DASHBOARD_NAMESPACES and DASHBOARD_NAMESPACES_ALL environment variables which serve as fallback for the namespaces and scan-all flags.
|
@fpetkovski thank's for the contribution. I think this makes sense. |
hubeadmin
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Great, Thanks @fpetkovski, nice addition, verified and tested locally on minikube, works as intended 👍
fpetkovski
added a commit
to fpetkovski/monitoring-stack-operator
that referenced
this pull request
Dec 13, 2021
This commit upgrades the Grafana Operator to 4.1.0 and configures the operator to scan dashboards from all namespace. This change was introduced in 4.0.2 [1]. grafana/grafana-operator#579
fpetkovski
added a commit
to fpetkovski/monitoring-stack-operator
that referenced
this pull request
Dec 13, 2021
This commit upgrades the Grafana Operator to 4.1.0 and configures the operator to scan dashboards from all namespace. This change was introduced in 4.0.2 [1]. grafana/grafana-operator#579
fpetkovski
added a commit
to rhobs/observability-operator
that referenced
this pull request
Dec 14, 2021
This commit upgrades the Grafana Operator to 4.1.0 and configures the operator to scan dashboards from all namespace. This change was introduced in 4.0.2 [1]. grafana/grafana-operator#579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently it's only possible to configure dashboard namespaces through
command line args. This makes it difficult to fine-tune the operator
when installing it declaratively through an OLM subscription.
This commit adds the
DASHBOARD_NAMESPACESandDASHBOARD_NAMESPACES_ALLenvironment variables which serve as fallback for the namespaces and
scan-all flags.
Relevant issues/tickets
Fixes #363
Type of change
Checklist
Verification steps
Run the operator with the following commands to verify the functionality:
POD_NAME="grafana-operator" WATCH_NAMESPACE="default" go run main.gouses current namespace for dashboardsPOD_NAME="grafana-operator" WATCH_NAMESPACE="default" DASHBOARD_NAMESPACES_ALL="true" go run main.go: uses all namespaces for dashboardsPOD_NAME="grafana-operator" WATCH_NAMESPACE="default" DASHBOARD_NAMESPACES="kube-system" go run main.go: uses kube-system namespace for dashboardsPOD_NAME="grafana-operator" WATCH_NAMESPACE="default" DASHBOARD_NAMESPACES="kube-system" go run main.go --namespaces default: uses default namespace for dasbhoards