Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for grafanadashboard using require #581

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Unit tests for grafanadashboard using require #581

merged 3 commits into from
Oct 27, 2021

Conversation

NissesSenap
Copy link
Collaborator

Description

A few simple unit tests around grafanadashboard.

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

make test

Edvin Norling added 2 commits October 21, 2021 21:54
hubeadmin
hubeadmin approved these changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, nice use of require, I'm going to use this in my other projects 👍

@NissesSenap NissesSenap merged commit 54b1b50 into grafana:master Oct 27, 2021
@NissesSenap NissesSenap deleted the test_dashboard branch October 27, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubeadmin hubeadmin hubeadmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NissesSenap @hubeadmin