-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#556: Adds example GrafanaDatasource for postgres #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment.
Thanks allot @Voigtus keep up the good work!
secureJsonData: | ||
password: admin123 # password of your user | ||
url: postgres.default.svc.cluster.local:5432 #change to url of your postgres instance | ||
user: postgresadmin # user to access your database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silly thing but I know I will think about it in the future. Trying to add \n at the end of all our yaml files.
It's on my todo to add a CI rule for this.
Other then that I think it looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
On further notice: Would it be a possibility to add an .editorconfig file to the repo?
It would be insured, that something like this might not happen as easily again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There have been talk about editorconfig before #516 if you want to take a look at it again please do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NissesSenap I force-pushed the change, can you approve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @Voigtus 👍
It seems that is example got lost and is not available anymore in the repo? |
@krzwiatrzyk it's in the v4 branch. But we would love a PR with a v5 version. |
I made it work, just change datasources (list) to datasource (object) and add an access: proxy field (Grafana was rejecting datasource without it) |
Great @krzwiatrzyk , we would love a PR with an example |
Here #1076 |
Description
Adds an example to use a postgres DB as GrafanaDatasource
Relevant issues/tickets
#556
Type of change
Verification steps