Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwardport from grafana-operator v3 the json data field implementation for Alertmanager Datasource. #601

Merged
merged 8 commits into from
Nov 9, 2021

Conversation

Cellebyte
Copy link
Contributor

Description

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

@Cellebyte
Copy link
Contributor Author

This adds more support to configure the Alertmanager Datasource with the [unified_alerting] from #559

@Cellebyte Cellebyte changed the title Forwardport/v3 json data field for Alertmanager Datasource. Forwardport from grafana-operator v3 the json data field implementation for Alertmanager Datasource. Nov 9, 2021
Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, one small nitpick

@Cellebyte
Copy link
Contributor Author

@HubertStefanski what is the small nitpick, when I click on the link it is not showing it up :D

Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, you caught it 😅 , not sure why it didn't show up, but it was that new line at EOF for the example .yaml, thanks @Cellebyte 👍

@NissesSenap
Copy link
Collaborator

More information can be found: https://grafana.com/docs/grafana/latest/datasources/alertmanager/

@NissesSenap NissesSenap merged commit ff99f71 into grafana:master Nov 9, 2021
@NissesSenap
Copy link
Collaborator

Thanks allot @Cellebyte and thanks for all that you do for the community by managing the grafana-operator helm chart for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants