Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for exemplarTraceIdDestinations (#681) #682

Conversation

johanderss
Copy link
Contributor

Description

Added support for exemplarTraceIdDestinations in Prometheus data source.

Relevant issues/tickets

#681

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johanderss Thanks for addressing this! Changes look good to me, any opinions @pb82 @NissesSenap @robshelly @vmanley ?

@vmanley
Copy link
Contributor

vmanley commented Feb 15, 2022

@HubertStefanski Seems fine to me

@NissesSenap
Copy link
Collaborator

LGTM

@NissesSenap NissesSenap merged commit 1b94fe6 into grafana:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants