-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable restricted network builds #709
Enable restricted network builds #709
Conversation
The error seems to be related to: hadolint/hadolint#339 This seems like a okay workaround to define it in What do you think @smuda ? |
@NissesSenap You are probably right, well found! I've moved the default values to the top which also makes it more readable. At the same time I also rebased on top of the current HEAD from master. To make sure images can be replaced I ran the following command and verified the output contained the new images:
To make sure GOPROXY can be replaced I ran the following command and watched as the network traffic did go the direct route to the dependencies:
|
@smuda this looks good, only needs a rebase |
Signed-off-by: John Allberg <john@ayoy.se>
@pb82 I rebased on top of master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay and thanks for the help @smuda
Description
When building the grafana operator from source within a network restricted environment, being able to use local images and GOPROXY/GOPRIVATE is a requirement.
Relevant issues/tickets
#707
Type of change
Checklist
Verification steps