Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the GetDashboards function is called for the re-sync it gets called with the namespace specified as the empty string, this wasn't accounted for in #690. So, after #690 the reconciliation of dashboards (for the periodic re-sync) started getting an empty list of known dashboards which then caused any checking of existing dashboards to fail.
Relevant issues/tickets
Some people have noticed that this started happening in 4.3.0 (myself included): #686 (comment)
Type of change
Checklist
Verification steps
Built and tested on my home cluster and seems to have solved the issue of new versions being created each sync period.
Docker image available here:
ghcr.io/addreas/grafana-operator:v4.3.0-690-bugfix