Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx GrafanaNotificationChannel cr not have UID will cause the program to crash #751

Merged
merged 2 commits into from
May 13, 2022
Merged

FIx GrafanaNotificationChannel cr not have UID will cause the program to crash #751

merged 2 commits into from
May 13, 2022

Conversation

gxg001
Copy link
Contributor

@gxg001 gxg001 commented May 9, 2022

Fix: [Bug] GrafanaNotificationChannel cr not have UID will cause the program to crash #747

Description

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

@gxg001
Update grafananotificationchannel_controller.go
b4c4d4a 
Fix: [Bug] GrafanaNotificationChannel cr not have UID will cause the program to crash grafana#747
@gxg001 gxg001 changed the title Update grafananotificationchannel_controller.go FIx GrafanaNotificationChannel cr not have UID will cause the program to crash May 9, 2022
hubeadmin
hubeadmin approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing @gitgaoxiang !

@NissesSenap NissesSenap merged commit 2cde511 into grafana:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubeadmin hubeadmin hubeadmin approved these changes

@NissesSenap NissesSenap NissesSenap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gxg001 @NissesSenap @hubeadmin